Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure release version is based on UTC timezone #125

Merged

Conversation

ReenigneArcher
Copy link
Member

Description

The timezone was not included when parsing the commit timestamp which could result in out of order release versions.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (46b8feb) to head (1be0cd2).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #125   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          166       174    +8     
=========================================
+ Hits           166       174    +8     
Files Coverage Δ
action/main.py 100.00% <100.00%> (ø)

@ReenigneArcher ReenigneArcher force-pushed the fix-ensure-release-version-is-based-on-UTC-timezone branch from bf8bf4c to 1be0cd2 Compare July 25, 2024 21:14
@ReenigneArcher ReenigneArcher merged commit c16fa14 into master Jul 25, 2024
11 checks passed
@ReenigneArcher ReenigneArcher deleted the fix-ensure-release-version-is-based-on-UTC-timezone branch July 25, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant